Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect use of AttachStatus #1222

Closed

Conversation

joseph-v
Copy link
Collaborator

@joseph-v joseph-v commented Feb 4, 2020

This PR fixes issue #1030

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #1222 into development will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           development    #1222   +/-   ##
============================================
  Coverage        34.84%   34.84%           
============================================
  Files               97       97           
  Lines            17652    17652           
============================================
  Hits              6151     6151           
  Misses           10629    10629           
  Partials           872      872
Impacted Files Coverage Δ
pkg/api/util/db.go 36.99% <0%> (ø) ⬆️

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v
Copy link
Collaborator Author

joseph-v commented Feb 5, 2020

Closing as this PR, as this will be redundant once, PR #1174 is merged

@joseph-v joseph-v closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants