-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snapshot fixes #1086
Open
Shruthi-1MN
wants to merge
1
commit into
sodafoundation:development
Choose a base branch
from
Shruthi-1MN:fileshare_snapshot_fixes
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
snapshot fixes #1086
Shruthi-1MN
wants to merge
1
commit into
sodafoundation:development
from
Shruthi-1MN:fileshare_snapshot_fixes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shruthi-1MN
force-pushed
the
fileshare_snapshot_fixes
branch
3 times, most recently
from
November 25, 2019 07:32
e635228
to
bed645d
Compare
Codecov Report
@@ Coverage Diff @@
## development #1086 +/- ##
===============================================
+ Coverage 34.92% 34.92% +<.01%
===============================================
Files 97 97
Lines 17563 17551 -12
===============================================
- Hits 6133 6129 -4
+ Misses 10561 10555 -6
+ Partials 869 867 -2
|
Shruthi-1MN
force-pushed
the
fileshare_snapshot_fixes
branch
3 times, most recently
from
November 26, 2019 11:27
a21c1af
to
e5f63c2
Compare
NajmudheenCT
previously approved these changes
Nov 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ThisIsClark
reviewed
Dec 2, 2019
Shruthi-1MN
force-pushed
the
fileshare_snapshot_fixes
branch
8 times, most recently
from
December 9, 2019 09:11
c3450e6
to
aafbb7a
Compare
This was referenced Dec 10, 2019
Shruthi-1MN
force-pushed
the
fileshare_snapshot_fixes
branch
from
December 11, 2019 08:43
aafbb7a
to
866e3f8
Compare
Shruthi-1MN
force-pushed
the
fileshare_snapshot_fixes
branch
from
December 11, 2019 09:03
866e3f8
to
71a0cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR has fix for the following bug #1066, #1067, #1069, #1070, #1071
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes # #1066, #1067, #1069, #1070, #1071Special notes for your reviewer:
Following criteria's are covered
#1066 Creating file share snapshot name with other encoding characters(except utf-8)
#1067 Creating file share snapshot name having special characters
#1069 Creating file share snapshot name length more than 99 characters
#1070 updating snapshot name special characters are not allowed
#1071 updating snapshot name should not be more than 99 characters
Release note: