bugfix(website): caching of transparency page #495
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
andrashee
changed the title
andrashee
changed the title
andrashee
changed the title
| @@ -26,7 +39,12 @@ export default async function Page(props: TransparencyPageProps) { | |||
| <Stats.Stat.Item variant="value">{contributionStats.totalContributions}</Stats.Stat.Item> | |||
| </Stats.Stat> | |||
| </Stats> | |||
| <TransparencyCharts contributionStats={contributionStats} paymentStats={paymentStats} {...props} /> | |||
| <TransparencyCharts | |||
There was a problem hiding this comment.
Did you realize that this is the absolute crucial change?
Without this change, the caching doesn't work. But with this change, it doesn't matter if you leave the getStats() function in a separate file, wrap it inside a cache() call, or specify export const revalidate = 3600;. All these things don't matter in this case. All that matters for the caching to work is to not use the spread (...) operator on the page props. I'm so confused 🤯. I guess it's never a good idea to use ...props with page components.
Obviously, specifying export const revalidate = 3600; makes sense; otherwise the stats are never updated.
There was a problem hiding this comment.
Oops, I only now saw your comment from above🙈😅 I'll merge the changes.
@mkue Like this, it works for me. It seems to me, that providing the
TransparencyPagePropsto theTransparencyChartsis causing the reevaluation ofgetStatsin each request. Something in there makes the caching obsolete. Providing the parameters explicitly, the caching and reevaluation seems to work fine.