Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recipient_app): Updated login registration flow #491

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

MDikkii
Copy link
Contributor

@MDikkii MDikkii commented Aug 2, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
public ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2023 8:27am

@MDikkii MDikkii force-pushed the mdikkii/415-new-login-registration branch from da540b2 to af8946e Compare August 4, 2023 07:17
@MDikkii MDikkii changed the title (wip) feat(recipient_app): Updated login registration flow feat(recipient_app): Updated login registration flow Aug 4, 2023
@MDikkii MDikkii marked this pull request as ready for review August 4, 2023 09:09
@MDikkii MDikkii requested a review from novas1r1 as a code owner August 4, 2023 09:09
}) async {
await firebaseAuth.verifyPhoneNumber(
phoneNumber: phoneNumber,
forceResendingToken: forceResendingToken,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to make sure that the same phone can be provided twice even if auto retrieval timeout hasn't passed yet.

@@ -37,6 +39,7 @@ class InputText extends StatelessWidget {
// labelText: hintText,
suffixIcon: suffixIcon,
floatingLabelBehavior: FloatingLabelBehavior.never,
counter: const SizedBox.shrink()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this good for and why is it empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the characters limit is added Flutter is adding the counter on the bottom of the text input automatically. Which is not what we want AFAIK. One of the solutions (which also make it not adding extra space to the bottom of input fields is like above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add this as a comment, otherwise we will stumble over this again :D?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure 👍

@MDikkii MDikkii merged commit fd27b8e into main Aug 8, 2023
18 checks passed
@MDikkii MDikkii deleted the mdikkii/415-new-login-registration branch August 8, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants