Clean xsd template #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll give the patch a spin but I agree - cleaning up the jinja template is sorrowly needed. Should I wait until #55 is merged? |
|
I prefer you wait for #55. |
It has two similar parts. They have some differences, but looks like it is just because the second part don't implement some `ListElement` features.
|
Do a good release now, after that we merge this PR. It is just lots of refactoring. |
|
I'm currently working on a number of fixes that need to be in before the release and I'm happy to check this over before then. |
|
👍 I think this pull request will help most of code generation changes in the future. |
|
@pope1ni @iurisilvio What's your feeling about merging this now? I think we can deal with any fallout as follow-up patches. |
|
This code is good. I'm using it in some cases. I don't know if @pope1ni validated it. 👍 for merge |
|
merged, thank you very much @iurisilvio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to simplify this XSD generation.
During this extraction, I found lots of code duplication (2d4380c).
I know it is a risk change, but it will be easier to future development.