fix: HEAD-679 only check snykgov.io domain to check if fedramp #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avishagp
reviewed
Sep 4, 2023
| @@ -196,16 +196,15 @@ export class Configuration implements IConfiguration { | |||
| get isFedramp(): boolean { | |||
| if (!this.customEndpoint) return false; | |||
|
|
|||
| // FEDRAMP URL e.g. https://api.fedramp.snykgov.io | |||
| // FEDRAMP URL e.g. https://api.feddramp.snykgov.io | |||
There was a problem hiding this comment.
I think just pointing out that the fedramp part is irrelevant (the domain is the trigger)
There was a problem hiding this comment.
Sorry yes, we check for snykgov.io only now
bastiandoetsch
approved these changes
Sep 4, 2023
Avishagp
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking for a "fedramp" part in the instance name is most likely not resilient enough, so we decided to only check the domain..
Checklist