chore: adding Nebula as GH owners [NEBULA-1290] #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metju90
commented
Jul 10, 2023
.github/CODEOWNERS
Outdated
| @@ -1,3 +1,5 @@ | |||
| * @snyk/hammerhead | |||
| src/snyk/common/services/learnService.ts @snyk/owl | |||
| src/test/unit/common/services/learnService.test.ts @snyk/owl | |||
| src/snyk/snykCode/codeSettings.ts @snyk/nebula | |||
| src/test/unit/snykCode/codeSettings.test.ts @snyk/nebula | |||
There was a problem hiding this comment.
@snyk/owl does not seem to exist anymore
metju90
changed the title
bastiandoetsch
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Hi @metju90 , I'll discuss with the team, if we want code-ownership of the codeSettings in VSCode with Nebula.
@bastiandoetsch shared ownership will be best. We want to be notified of potentially breaking changes for local-engine. |
|
@bastiandoetsch Code files are now co-owned between hammerhead, zenith and nebula |
bastiandoetsch
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding team Nebula as code owners for files that could break local-engine