Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error message when no breaking changes detected #393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve error message when no breaking changes detected #393

wants to merge 1 commit into from

Conversation

tinygrasshopper
Copy link
Contributor

Current error message example:

...
2024/10/23 12:40:30 no breaking change detected between versions 2024-10-15 00:00:00 +0000 UTC and 2024-10-23 00:00:00 +0000 UTC:
 [{endpoint-added []  info POST createOrgAssignments /orgs/{org_id}/learn/assignments   %!s(int=0) %!s(int=0) %!s(int=0) %!s(int=0)}]

@tinygrasshopper tinygrasshopper requested a review from a team as a code owner October 30, 2024 17:22
jgresty
jgresty approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jgresty jgresty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to link out to some documentation explaining why developers need to merge up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaduPetreTarean RaduPetreTarean RaduPetreTarean approved these changes

@jgresty jgresty jgresty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinygrasshopper @jgresty @RaduPetreTarean