fix: JsonReaderException unexpected character encountered while parsi…

…ng (#113)
snyk · Apr 4, 2022 · ef05143 · ef05143
1 parent b9561c0
commit ef05143
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/Snyk.VisualStudio.Extension.Shared/Service/SnykApiService.cs b/Snyk.VisualStudio.Extension.Shared/Service/SnykApiService.cs
@@ -39,7 +39,15 @@ public async Task<SastSettings> GetSastSettingsAsync()
             var response = await this.SendSastSettingsRequestAsync();
             var responseContent = await response.Content.ReadAsStringAsync();
 
-            return Json.Deserialize<SastSettings>(responseContent);
+            try
+            {
+                return Json.Deserialize<SastSettings>(responseContent);
+            }
+            catch (Exception e)
+            {
+                // In case of invalid json string return null.
+                return null;
+            }
         }
 
         /// <inheritdoc/>

diff --git a/Snyk.VisualStudio.Extension.Tests/SnykApiServiceTest.cs b/Snyk.VisualStudio.Extension.Tests/SnykApiServiceTest.cs
@@ -77,5 +77,25 @@ public async Task SnykApiService_InvalidAuthTokenProvided_ReturnNullAsync()
 
             Assert.Null(sastSettings);
         }
+
+        [Fact]
+        public async Task SnykApiService_InvalidUrlProvided_ReturnNullAsync()
+        {
+            var optionsMock = new Mock<ISnykOptions>();
+
+            optionsMock
+                .Setup(options => options.CustomEndpoint)
+                .Returns("https://snyk.io/");
+
+            optionsMock
+                .Setup(options => options.ApiToken)
+                .Returns(Environment.GetEnvironmentVariable("TEST_API_TOKEN"));
+
+            var apiService = new SnykApiService(optionsMock.Object);
+
+            var sastSettings = await apiService.GetSastSettingsAsync();
+
+            Assert.Null(sastSettings);
+        }
     }
 }