fix: DRA helm chart installs failing #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,2 +1,6 @@ | |||
| * @snyk/team-broker | |||
|
|
|||
| charts/snyk-broker/templates/cra_deployment.yaml @snyk/container-integration | |||
There was a problem hiding this comment.
I think the codeownership should be broker team only to align with:
There was a problem hiding this comment.
It's not exactly the same though. This here is the deployment of the agent, not the CRA flavored broker. So I agree for the broker repo but here this is a distinct deployment and the specifics of what env vars are needed etc are a bit unknown to us, so I'd keep it that way.
ahmed-agabani-snyk
approved these changes
Oct 13, 2023
pavel-snyk
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is regarding issues after the changes introduced in this PR.
Issues were reported by the customer in this ticket:
https://snyk.zendesk.com/agent/tickets/58273
and it regards mismatches in the Helm Chart variables which are causing the Helm installation of the brokered CRA to fails.
What this is doing
I have addressed in this PR the comments from the customer in order to have a starting point for the discussion.
I think such scenarios should be caught by tests.
Reviewer's note
Would be better to review commit by commit. One of the commits it's adding container-integration as code ownders for the CRA files.