fix: extra pod specs for cra #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
soniqua
force-pushed
the
fix/extra-pod-specs-cra
branch
from
1bda138
to
5b05e0e
Compare
|
@soniqua, could you add an helm unittest to verify usage of |
soniqua
force-pushed
the
fix/extra-pod-specs-cra
branch
from
3190452
to
205b825
Compare
soniqua
force-pushed
the
fix/extra-pod-specs-cra
branch
from
205b825
to
d0dc981
Compare
pavel-snyk
reviewed
Apr 16, 2024
Comment on lines
+15
to
+16
| path: spec.template.spec | ||
| template: broker_deployment.yaml |
There was a problem hiding this comment.
@soniqua, nice usage instead of giga-snapshot :)
pavel-snyk
approved these changes
Apr 16, 2024
jonnyowenpowell
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
extraPodSpecsto be specified for Container Registry Agent