fix: make JavaScript usable in Snyk Report tab (CLI-268) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schottsfired
force-pushed
the
fix/CLI-268
branch
from
821f469 to
59301df
Compare
schottsfired
force-pushed
the
fix/CLI-268
branch
3 times, most recently
from
afb2c60 to
3a437cd
Compare
schottsfired
force-pushed
the
fix/CLI-268
branch
from
532353b to
0ab5ee4
Compare
schottsfired
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI-268
Problem:
After running a build, the Snyk Report tab includes a report with
Data FlowandFix Analysistabs that do nothing when clicked. The browser console shows the following error message:(
toggleCardViewis a JS function in the included<script>section of the report)Solution:
After modifying the HTML template to use an
<iframe>, and adjusting the backend logic for filling the iframe, JavaScript is working as expected.How to Test:
Navigate to this build in dev and compare the two Snyk Report tabs. The one on the left is production, and the one on the right is this PR.