Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (test, monitor): Fix dotnet UTF-16LE support for target framework #5701

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

37IulianPopovici
Copy link
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Fixes an issue with the nuget cli scanner not being able to process files encoded with UTF-16LE

Where should the reviewer start?

snyk/snyk-nuget-plugin#232

How should this be manually tested?

Can be manually tested with this fixture

automated test here

@37IulianPopovici 37IulianPopovici self-assigned this Jan 30, 2025
@37IulianPopovici 37IulianPopovici requested a review from a team as a code owner January 30, 2025 11:26
@PeterSchafer
Copy link
Collaborator

Thank you @37IulianPopovici!

Looks good to me! I only have one ask, could you please change the commit message to be more understandable on its own in our release notes.

For example something like

fix (test, monitor): Fix dotnet UTF-16LE support for target framework

@37IulianPopovici 37IulianPopovici force-pushed the fix/utf16le-support-for-target-framework branch from 35adef7 to 7e8ba8f Compare January 30, 2025 12:18
@37IulianPopovici
Copy link
Contributor Author

Thank you @37IulianPopovici!

Looks good to me! I only have one ask, could you please change the commit message to be more understandable on its own in our release notes.

For example something like

fix (test, monitor): Fix dotnet UTF-16LE support for target framework

done, thank you!

@37IulianPopovici 37IulianPopovici force-pushed the fix/utf16le-support-for-target-framework branch from 7e8ba8f to 1e64aa7 Compare January 30, 2025 12:21
@37IulianPopovici 37IulianPopovici changed the title fix: utf16le support for target framework fix (test, monitor): Fix dotnet UTF-16LE support for target framework Jan 30, 2025
@37IulianPopovici 37IulianPopovici force-pushed the fix/utf16le-support-for-target-framework branch from 1e64aa7 to 1d6672c Compare January 30, 2025 12:33
@37IulianPopovici 37IulianPopovici force-pushed the fix/utf16le-support-for-target-framework branch from 1d6672c to e90075a Compare January 30, 2025 14:07
@37IulianPopovici 37IulianPopovici merged commit 59e5caf into main Feb 3, 2025
7 checks passed
@37IulianPopovici 37IulianPopovici deleted the fix/utf16le-support-for-target-framework branch February 3, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants