Fix gpspipe argument incompatibility in constants.py for Rocky Linux 8 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Linux 8 Body: On Rocky Linux 8 with gpspipe version 3.19, the `--json` argument is unsupported, causing Lincot to fail during execution. The issue was reported in GitHub issue #[Issue_Number]. The constants.py file contained a string `DEFAULT_GPS_INFO_CMD` which was using this incompatible `--json` argument. This commit replaces the `--json` argument with `-w` in the `DEFAULT_GPS_INFO_CMD` string, making the gpspipe command compatible across different versions. File Changed: - Modified DEFAULT_GPS_INFO_CMD in constants.py from `gpspipe --json -n 5` to `gpspipe -w -n 5`. Tested: - Manually tested on Rocky Linux 8 with gpspipe version 3.19 and confirmed that Lincot now runs without errors. This change should make Lincot more robust and compatible across different Linux distributions and gpspipe versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
gpspipeArgument Incompatibility inconstants.pyfor Rocky Linux 8Summary
On Rocky Linux 8 with
gpspipeversion 3.19, the--jsonargument is unsupported. This causes Lincot to fail during execution. This issue was reported in GitHub issue #[Issue_Number].Details
The
constants.pyfile contained a stringDEFAULT_GPS_INFO_CMDthat was using this incompatible--jsonargument. This commit replaces the--jsonargument with-win theDEFAULT_GPS_INFO_CMDstring, making thegpspipecommand compatible across different versions.File Changed
DEFAULT_GPS_INFO_CMDinconstants.pyFrom:
gpspipe --json -n 5To:
gpspipe -w -n 5Testing
gpspipeversion 3.19.Conclusion
This change should make Lincot more robust and compatible across different Linux distributions and
gpspipeversions.