Don't use Java properties to pass configuration in kinesis integratio…

…n tests

kinesis/src/it/resources/collector-cookie-attributes-1.hocon

@@ -0,0 +1,30 @@
+collector {
+  interface = "0.0.0.0"
+  port = ${PORT}
+
+  streams {
+    good = ${STREAM_GOOD}
+    bad = ${STREAM_BAD}
+
+    sink {
+      region = ${REGION}
+      customEndpoint = ${KINESIS_ENDPOINT}
+
+      aws {
+        accessKey = env
+        secretKey = env
+      }
+
+      maxBytes = ${MAX_BYTES}
+    }
+  }
+
+  "cookie": {
+    "enabled": true,
+    "name": "greatName",
+    "expiration": "42 days",
+    "secure": true,
+    "httpOnly": true,
+    "sameSite": "Strict"
+  }
+}

kinesis/src/it/scala/com/snowplowanalytics/snowplow/collectors/scalastream/it/core/CookieSpec.scala

@@ -29,34 +29,17 @@ class CookieSpec extends Specification with Localstack with CatsEffect {
   override protected val Timeout = 5.minutes
 
   "collector" should {
-
     "set cookie attributes according to configuration" in {
-
       "name, expiration, secure true, httpOnly true, SameSite" in {
         val testName = "cookie-attributes-1"
-        val streamGood = s"${testName}-raw"
-        val streamBad = s"${testName}-bad-1"
-
-        val name = "greatName"
-        val expiration = 42 days
-        val secure = true
-        val httpOnly = true
-        val sameSite = SameSite.Strict
+        val streamGood = s"$testName-raw"
+        val streamBad = s"$testName-bad-1"
 
         Collector.container(
-          "kinesis/src/it/resources/collector.hocon",
+          "kinesis/src/it/resources/collector-cookie-attributes-1.hocon",
           testName,
           streamGood,
-          streamBad,
-          additionalConfig = Some(
-            mkConfig(
-              name = name,
-              expiration = expiration,
-              secure = secure,
-              httpOnly = httpOnly,
-              sameSite = sameSite.toString()
-            )
-          )
+          streamBad
         ).use { collector =>
           val request = EventGenerator.mkTp2Event(collector.host, collector.port)
 
@@ -66,16 +49,16 @@ class CookieSpec extends Specification with Localstack with CatsEffect {
           } yield {
             resp.cookies match {
               case List(cookie) =>
-                cookie.name must beEqualTo(name)
+                cookie.name must beEqualTo("greatName")
                 cookie.expires match {
                   case Some(expiry) =>
-                    expiry.epochSecond should beCloseTo((now + expiration).toSeconds, 10)
+                    expiry.epochSecond should beCloseTo((now + 42.days).toSeconds, 10)
                   case None =>
                     ko(s"Cookie [$cookie] doesn't contain the expiry date")
                 }
                 cookie.secure should beTrue
                 cookie.httpOnly should beTrue
-                cookie.sameSite should beEqualTo(sameSite)
+                cookie.sameSite should beSome(SameSite.Strict)
               case _ => ko(s"There is not 1 cookie but ${resp.cookies.size}")
             }
           }