Add tracker.getQueueName method #1217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles added (6)
Total files change +95.43KB 0% Final result: ✅ View report in BundleMon website ➡️ |
greg-el
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Looks good! Just a couple of thoughts I've had on the types.
I think I'm not properly following the types you've used here. I can see both:
'post' | 'get' | undefinedExclude<EventMethod, 'beacon'>
This seems to boil down to the same type, a potentially optional 'post' | 'get'. Could it be clearer to create a type alias for Exclude<EventMethod, 'beacon'>, which then could be used with ? as required?
| /** | ||
| * Returns the currently used queue name or if the `eventMethod` argument is provided, the queue name for the eventMethod. | ||
| */ | ||
| getQueueName: (eventMethod?: 'post' | 'get' | undefined) => string; |
There was a problem hiding this comment.
nit: This can be eventMethod?: 'post' | 'get' if you are using ?, right?
There was a problem hiding this comment.
This slipped in the PR, should be Exclude<EventMethod, 'beacon'> as in the implementation.
jethron
approved these changes
Jun 30, 2023
igneel64
force-pushed
the
feature/1215-expose-queue-name
branch
from
d27ef2d
to
f286ece
Compare
greg-el
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
tracker.getQueueNamemethod.This method will return the currently used queue name or if provided arguments will return the one that would be used with the provided
eventMethod.close #1215