Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1895435- Expand the documentation - signing verification #997

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Jan 24, 2025

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

README.md Show resolved Hide resolved
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (67d0c25) to head (1a5089a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
- Coverage   88.97%   88.96%   -0.02%     
==========================================
  Files          72       72              
  Lines        6985     6985              
==========================================
- Hits         6215     6214       -1     
- Misses        770      771       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit bb3dac8 into master Jan 24, 2025
44 of 45 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1895435 branch January 24, 2025 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
@sfc-gh-pmotacki sfc-gh-pmotacki restored the SNOW-1895435 branch January 24, 2025 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants