Add project commands #2018
Add project commands #2018
Conversation
sfc-gh-turbaszek
force-pushed
the
dcm-project
branch
from
88b8fcd to
b492dd2
Compare
sfc-gh-turbaszek
force-pushed
the
dcm-project
branch
2 times, most recently
from
f795342 to
a4a3209
Compare
sfc-gh-turbaszek
force-pushed
the
dcm-project
branch
from
a4a3209 to
16bbb79
Compare
|
|
||
| @unique | ||
| class FeatureFlag(FeatureFlagMixin): | ||
| ENABLE_SNOWFLAKE_PROJECTS = BooleanFlag("ENABLE_NATIVE_APP_PYTHON_SETUP", False) |
There was a problem hiding this comment.
Is this correct with ENABLE_NATIVE_APP_PYTHON_SETUP?
| cli_console.step(f"Creating stage {stage_name}") | ||
| sm.create(fqn=stage_name) | ||
|
|
||
| for file in project.artifacts: |
There was a problem hiding this comment.
Does this take care of replacing existing files on the stage with the same name? What about files already living on the stage directory used to feed the project. Are they being deleted when they don't existing in the new version?
Maybe each snow project create-version should create a subdirectory on the stage that is prefixed with a unique identifier / the version name?
|
|
||
| @app.command(requires_connection=True) | ||
| @with_project_definition() | ||
| def create_version( |
There was a problem hiding this comment.
Are we gonna have an init command?
There was a problem hiding this comment.
Oh I see, create_version creates project if doesn't exist.
|
|
||
|
|
||
| @unique | ||
| class FeatureFlag(FeatureFlagMixin): |
There was a problem hiding this comment.
Can we show this feature only for PrPr customers?
|
|
||
| @app.command(requires_connection=True) | ||
| @with_project_definition() | ||
| def create_version( |
There was a problem hiding this comment.
I have some doubts about this command:
- both execute and validate commands map directly to a single project SQL command, the create_version command suggests that it maps to
alter project p add version, but it does much more - we should have a command which maps to the basic
alter project p add version. I don't see how this will work with snow-git-based projects. If we add a basic "add version" command, then it can be used by users to create a version from any stage, also a snow-git-based one. And it can be used in this more complex command. - Imo the name should be more explicit, like, create_version_from_local_files or something like that.
Pre-review checklist
Changes description
Add
snow projectcommands hidden behind a feature flag.