Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Fakegato history #157

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Implementation of Fakegato history #157

wants to merge 25 commits into from

Conversation

ctschach
Copy link
Contributor

The following changes have been added:

  • Added eve-related ServiceTypes and Characteristics
  • Added support for Fakegate-History (History in eve Homekit app)
  • Added easier support for custom ServicesTypes and Characteristics via CustomHomeKitTypes.
  • Added support for DPT12, DPT13, DPT14 (to support 4-byte integer and float values)
  • Added a bunch of custom Handlers (mostly used for eve implementation)
    • Added custom Handler "HistoryMotion" to manage additional characteristics used by Eve motion.
    • Added custom Handler "HistoryDoor" to manage additional characteristics used by Eve door.
    • Added custom Handler "HistoryPower" to manage additional characteristics used by Eve Power / Eve Outlet.
    • Added custom Handler "ValveControl" to support a Sprinkler System with automatic timeout

I'm still a big confused why the file comparison how things like:

var AccConstructor = require('./lib/knxdevice.js');
.vs.
var KNXDevice = require('./lib/knxdevice.js');

In the current master's index.js it says KNXDevice and so it does in my index.js. No idea where this AccConstructor comes from.

@snowdd1
Copy link
Owner

snowdd1 commented Feb 13, 2020

Hi Carsten, that is great! However, it seems to be based on v0.3.19 instead of the current master, and that is why the file compare shows ancient artifacts, like the AccConstructor, which was the historic name back when it was a part of HAP-nodejs, long before Homebridge.

Could you try to re-base the pull request to the newest master? I found that here: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request
but I recommend making multiple backup copies in different physical locations :-)

Besides that, I really like it!

@ctschach
Copy link
Contributor Author

Hmmm..this is pretty strange. I pulled the current version from "your" Github version and compared it file by file with "my" version. Everything looks pretty okay.

But I'll have a look at the Rebase and see if I can get this to work.

@snowdd1
Copy link
Owner

snowdd1 commented Feb 18, 2020

Year, I think Git remembers when you forked the branch and bases everything on that version. So even if your files are identical to the current master, it will show the differences to 0.3.19 or whatever the base version was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants