Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Injector plugin requires all annotations in the injected function #201

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Daverball
Copy link
Collaborator

Closes: #188
Closes: #189

This also switches to using lookup_full_name

@Daverball Daverball merged commit c81ff55 into snok:main Dec 13, 2024
6 checks passed
@Daverball Daverball deleted the fix/injector-plugin branch December 13, 2024 13:07
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.5%. Comparing base (7621d51) to head (aaeb5ea).
Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
flake8_type_checking/checker.py 75.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #201     +/-   ##
=======================================
- Coverage   98.7%   96.5%   -2.3%     
=======================================
  Files          3       4      +1     
  Lines        482     980    +498     
=======================================
+ Hits         476     946    +470     
- Misses         6      34     +28     
Files with missing lines Coverage Δ
flake8_type_checking/checker.py 96.2% <75.0%> (-2.4%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Injector library requires all annotation to be available in runtime
1 participant