This repository has been archived by the owner on Nov 19, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate_unique_items()
validator had a known issue where it could not validatedict
objects in any way. Attempting to pass one would result in an immediateTypeError: unhashable type: 'dict'
.This merge request adds support for validating
dict
objects by serializing them to ordered JSON strings and doing the comparison with those. I imagine that this solution might not be flexible enough to handle every possibledict
but it should be better than not being able to handle anydict
. And since we are talking about data returned by an API, it's quite likely that the data passed to the validator will actually be JSON serializable.