Support groups query customization #352
Open
+67
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _ms_request conslidates the error handling logic into a single method. This should make overriding methods easier for end users.
JonasKs
reviewed
Oct 18, 2024
| Docs: | ||
| https://learn.microsoft.com/en-us/graph/api/group-list-transitivememberof?view=graph-rest-1.0&tabs=python#http-request | ||
| """ | ||
| return {} |
There was a problem hiding this comment.
I'm reading this on my phone, but I'm a bit confused here. This function does nothing?
There was a problem hiding this comment.
Ah, I just read the docs. Should've scrolled before I commented!
I wouldn't mind a default implementation here, but I'm also fine with this.
There was a problem hiding this comment.
Personally, I lean towards not having a default to avoid breaking existing integrations. I don't hold that strongly though. If you suggest a default, I'm happy to include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #274
Fixes #272