chore: update lint to 1.56.2 and fix lint errors

.github/workflows/ci-workflow.yml

@@ -14,7 +14,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.54.2
+          version: v1.56.2
           args: --verbose
 
   test:

collections/collections-suite_test.go

@@ -3,8 +3,8 @@ package collections_test
 import (
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 )
 
 func TestCollections(t *testing.T) {

collections/gomega-stack-matchers_test.go

@@ -3,9 +3,7 @@ package collections_test
 import (
 	"fmt"
 
-	// . "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
-	// . "github.com/onsi/gomega/matchers"
+	. "github.com/onsi/gomega" //nolint:revive // gomega ok
 
 	"github.com/onsi/gomega/types"
 	"github.com/snivilised/extendio/collections"

collections/iterators_test.go

@@ -4,8 +4,8 @@ import (
 	"fmt"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 
 	"github.com/snivilised/extendio/collections"
@@ -635,7 +635,7 @@ var _ = Describe("Iterators", func() {
 
 							return nil
 						}
-						while := func(_ sleeve, err error) bool {
+						while := func(_ sleeve, _ error) bool {
 							return true
 						}
 
@@ -658,7 +658,7 @@ var _ = Describe("Iterators", func() {
 
 							return nil
 						}
-						while := func(s sleeve, err error) bool {
+						while := func(s sleeve, _ error) bool {
 							return strings.HasPrefix(s.song(), "0")
 						}
 
@@ -683,7 +683,7 @@ var _ = Describe("Iterators", func() {
 
 							return nil
 						}
-						while := func(_ sleeve, err error) bool {
+						while := func(_ sleeve, _ error) bool {
 							return true
 						}
 
@@ -706,7 +706,7 @@ var _ = Describe("Iterators", func() {
 
 							return nil
 						}
-						while := func(s sleeve, err error) bool {
+						while := func(s sleeve, _ error) bool {
 							return strings.HasPrefix(s.song(), "BONUS")
 						}
 

collections/stack_test.go

@@ -1,8 +1,8 @@
 package collections_test
 
 import (
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 
 	"github.com/snivilised/extendio/collections"
 )

i18n/i18n_suite_test.go

@@ -3,8 +3,8 @@ package i18n_test
 import (
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 )
 
 func TestI18n(t *testing.T) {

i18n/text_test.go

@@ -4,8 +4,8 @@ import (
 	"errors"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	xi18n "github.com/snivilised/extendio/i18n"
 	"github.com/snivilised/extendio/internal/helpers"
 	"github.com/snivilised/extendio/xfs/utils"

i18n/translator_test.go

@@ -4,8 +4,8 @@ import (
 	"fmt"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"golang.org/x/text/language"
 
 	"github.com/snivilised/extendio/i18n"

xfs/nav/bootstrapper.go

@@ -41,11 +41,11 @@ func (b *bootstrapper) initFilters() {
 
 func (b *bootstrapper) initNotifiers() {
 	if b.o.Notify.OnStart == nil {
-		b.o.Notify.OnStart = func(description string) {}
+		b.o.Notify.OnStart = func(_ string) {}
 	}
 
 	if b.o.Notify.OnStop == nil {
-		b.o.Notify.OnStop = func(description string) {}
+		b.o.Notify.OnStop = func(_ string) {}
 	}
 
 	b.nc.frame.notifiers.init(&b.o.Notify)

xfs/nav/filter-extended-glob_test.go

@@ -3,13 +3,13 @@ package nav_test
 import (
 	"fmt"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 
 	"github.com/snivilised/extendio/internal/helpers"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 	"github.com/snivilised/extendio/xfs/nav"
 )
 

xfs/nav/filter-glob.go

@@ -31,7 +31,7 @@ type CompoundGlobFilter struct {
 // Matching returns the collection of files contained within this
 // item's folder that matches this filter.
 func (f *CompoundGlobFilter) Matching(children []fs.DirEntry) []fs.DirEntry {
-	return lo.Filter(children, func(entry fs.DirEntry, index int) bool {
+	return lo.Filter(children, func(entry fs.DirEntry, _ int) bool {
 		matched, _ := filepath.Match(f.Pattern, entry.Name())
 		return f.invert(matched)
 	})

xfs/nav/filter-glob_test.go

@@ -3,13 +3,13 @@ package nav_test
 import (
 	"fmt"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 
 	"github.com/snivilised/extendio/internal/helpers"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 	"github.com/snivilised/extendio/xfs/nav"
 )
 

xfs/nav/filter-poly_test.go

@@ -4,11 +4,11 @@ import (
 	"fmt"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 	"github.com/snivilised/extendio/internal/helpers"
 	"github.com/snivilised/extendio/xfs/nav"
 )
@@ -356,7 +356,7 @@ var _ = Describe("FilterPoly", Ordered, func() {
 				o.Store.FilterDefs = filterDefs
 				o.Callback = &nav.LabelledTraverseCallback{
 					Label: "(panic): test poly filter callback",
-					Fn: func(item *nav.TraverseItem) error {
+					Fn: func(_ *nav.TraverseItem) error {
 						return nil
 					},
 				}

xfs/nav/filter-regex.go

@@ -42,7 +42,7 @@ func (f *CompoundRegexFilter) Validate() {
 }
 
 func (f *CompoundRegexFilter) Matching(children []fs.DirEntry) []fs.DirEntry {
-	return lo.Filter(children, func(entry fs.DirEntry, index int) bool {
+	return lo.Filter(children, func(entry fs.DirEntry, _ int) bool {
 		return f.invert(f.rex.MatchString(entry.Name()))
 	})
 }

xfs/nav/filter-regex_test.go

@@ -4,13 +4,13 @@ import (
 	"fmt"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 
 	"github.com/snivilised/extendio/internal/helpers"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 	"github.com/snivilised/extendio/xfs/nav"
 )
 

xfs/nav/gomega-matchers_test.go

@@ -3,7 +3,7 @@ package nav_test
 import (
 	"fmt"
 
-	. "github.com/onsi/gomega/types"
+	. "github.com/onsi/gomega/types" //nolint:revive // gomega ok
 	"github.com/snivilised/extendio/xfs/nav"
 )
 

xfs/nav/helpers_test.go

@@ -10,8 +10,8 @@ import (
 	"path/filepath"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 	"github.com/snivilised/extendio/i18n"
 	"github.com/snivilised/extendio/internal/helpers"

xfs/nav/hook-extend.go

@@ -50,9 +50,11 @@ func DefaultExtendHookFn(navi *NavigationInfo, entries *DirectoryContents) {
 		func() string {
 			result := subpath
 			sep := string(filepath.Separator)
+
 			if strings.HasSuffix(subpath, sep) {
 				result = subpath[:strings.LastIndex(subpath, sep)]
 			}
+
 			return result
 		},
 	)

xfs/nav/marshal-state_test.go

@@ -4,12 +4,12 @@ import (
 	"fmt"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 
 	"github.com/snivilised/extendio/internal/helpers"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 	"github.com/snivilised/extendio/xfs/nav"
 )
 
@@ -98,7 +98,7 @@ var _ = Describe("MarshalOptions", Ordered, func() {
 					o.Store.FilterDefs = &filterDefs
 					o.Callback = &nav.LabelledTraverseCallback{
 						Label: "test marshal state callback",
-						Fn: func(item *nav.TraverseItem) error {
+						Fn: func(_ *nav.TraverseItem) error {
 							return nil
 						},
 					}

xfs/nav/nav-suite_test.go

@@ -3,8 +3,8 @@ package nav_test
 import (
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 )
 
 func TestNav(t *testing.T) {

xfs/nav/navigation-async_test.go

@@ -7,8 +7,8 @@ import (
 	"time"
 
 	"github.com/fortytw2/leaktest"
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 	"go.uber.org/zap/exp/zapslog"
 	"go.uber.org/zap/zapcore"
@@ -17,7 +17,7 @@ import (
 	"github.com/snivilised/extendio/xfs/nav"
 	"github.com/snivilised/lorax/boost"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 )
 
 var (

xfs/nav/navigation-listener_test.go

@@ -4,12 +4,12 @@ import (
 	"fmt"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"github.com/samber/lo"
 	"github.com/snivilised/extendio/internal/helpers"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 	"github.com/snivilised/extendio/xfs/nav"
 )
 

xfs/nav/navigation-with-runner_test.go

@@ -6,16 +6,16 @@ import (
 	"time"
 
 	"github.com/fortytw2/leaktest"
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo ok
+	. "github.com/onsi/gomega"    //nolint:revive // gomega ok
 	"go.uber.org/zap/exp/zapslog"
 	"go.uber.org/zap/zapcore"
 
 	"github.com/snivilised/extendio/internal/helpers"
 	"github.com/snivilised/extendio/xfs/nav"
 	"github.com/snivilised/lorax/boost"
 
-	. "github.com/snivilised/extendio/i18n"
+	. "github.com/snivilised/extendio/i18n" //nolint:revive // i18n ok
 )
 
 var _ = Describe("NavigationWithRunner", Ordered, func() {

xfs/nav/new-filter.go

@@ -20,7 +20,7 @@ func fromExtendedGlobPattern(pattern string) (segments, suffixes []string, err e
 	segments = strings.Split(pattern, "|")
 	suffixes = strings.Split(segments[1], ",")
 
-	suffixes = lo.Reject(suffixes, func(item string, index int) bool {
+	suffixes = lo.Reject(suffixes, func(item string, _ int) bool {
 		return item == ""
 	})
 

xfs/nav/read-entries.go

@@ -21,7 +21,7 @@ func ReadEntriesHookFn(dirname string) ([]fs.DirEntry, error) {
 		return nil, err
 	}
 
-	return lo.Filter(contents, func(item fs.DirEntry, index int) bool {
+	return lo.Filter(contents, func(item fs.DirEntry, _ int) bool {
 		return item.Name() != ".DS_Store"
 	}), nil
 }

xfs/nav/resume-strategy-spawn.go

@@ -135,6 +135,7 @@ func (s *spawnStrategy) following(params *followingParams) *shard {
 		if params.inclusive {
 			return item.Name() >= params.anchor
 		}
+
 		return item.Name() > params.anchor
 	})
 	siblings := groups[followingSiblings]