Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certs: Use TWEAK domain certs if set #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rijul-A
Copy link

@Rijul-A Rijul-A commented Mar 12, 2022

Web proxy extension of snikket-im/snikket-server#69

@Rijul-A Rijul-A marked this pull request as ready for review April 1, 2023 18:49
@mwild1
Copy link
Member

mwild1 commented Oct 24, 2023

👋

I'm trying to piece things together so we could rebase and merge this PR prior to the upcoming release. I'm not aiming for full support of split-domain setups in this release, but I'd like to make any small safe steps that we can towards it. This seems like one!

I see that SNIKKET_TWEAK_CERT_DOMAIN is being pulled from SNIKKET_TWEAK_XMPP_DOMAIN. But in the case of a split-domain setup, we want nginx to have certs for the web domain, right?

@Rijul-A
Copy link
Author

Rijul-A commented Oct 24, 2023

Hey Matt! How have you been?

I have forgotten some of what I wrote back then but you are correct. If SNIKKET_TWEAK_XMPP_DOMAIN is set, the jids are of the form user@SNIKKET_TWEAK_XMPP_DOMAIN and the web portal is still hosted on SNIKKET_DOMAIN. This means that certificates for SNIKKET_DOMAIN should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants