Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document there is no backpressure on HTTP2 #283

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

josevalim
Copy link
Contributor

@josevalim josevalim commented Aug 3, 2024

Relates to #282.

@hissssst
Copy link

hissssst commented Aug 3, 2024

I think that it is also worth documenting for async_stream too. And overall approach must be pull model over push model, that means that async_stream needs to be reworked too

@josevalim
Copy link
Contributor Author

async_request already documents that it is a firehose. I think it is pretty much meant to be a fire and forget. If you want back-pressure, then I think pointing to one of the stream functions is fine.

@sneako
Copy link
Owner

sneako commented Aug 5, 2024

Thank you!

@sneako sneako merged commit 59e035b into sneako:main Aug 5, 2024
2 checks passed
@hissssst hissssst mentioned this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants