Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type Finch.request_opt() was missing the :request_timeout option #278

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Mayeu
Copy link
Contributor

@Mayeu Mayeu commented Jul 20, 2024

Hello 👋

First, thank you for your work on Finch 🙏

We encountered the following dyalixir error in our code:

lib/app/rpc.ex:352:no_return
Function post/2 has no local return.

Our function was only calling Finch.build(...) |> Finch.resquest(...) so nothing that could have raised. In this end, this was triggered because the :request_timeout keyword was missing from the Finch.request_opt() type.

@Mayeu
Copy link
Contributor Author

Mayeu commented Jul 20, 2024

I forced push to fix the linting error the CI reported.

@sneako
Copy link
Owner

sneako commented Jul 23, 2024

Thank you!!

@sneako sneako merged commit 047a417 into sneako:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants