Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mint.HTTP1 in HTTP1 conn #270

Closed
wants to merge 1 commit into from

Conversation

whatyouhide
Copy link
Contributor

@sneako
Copy link
Owner

sneako commented Apr 30, 2024

Hey @whatyouhide ! Thanks for the PR. I guess we should also remove this part of the docs: https://github.com/sneako/finch/pull/250/files#diff-bfab6b899762596b9df3f3d7e719f23d973285f555d89dd956cfd59e652a7a25R60-R61

@wojtekmach want to make sure you see this, did you have any ideas for a workaround in Req?

@wojtekmach
Copy link
Contributor

Wait are we basically reverting #250 or I'm missing something? It's fine if that is the plan i.e. we can't make it work but want to make sure.

@sneako
Copy link
Owner

sneako commented Apr 30, 2024

Yeah that is what would happen if we merge this PR... I do think Req should be able to support arbitrary protocols for unknown hosts, so I'm not sure if we should proceed this way.

I guess the only alternative we have thought of so far is to "port HTTP/2 flow control in HTTP/1 connections" as @wojtekmach mentioned in the linked comment?

@whatyouhide
Copy link
Contributor Author

Okay, let's close this and figure out a good solution in #265 first.

@whatyouhide whatyouhide closed this May 2, 2024
@whatyouhide whatyouhide deleted the al/http1-conn branch May 2, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants