Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tying up loose ends #48

Open
sneakernets opened this issue Mar 15, 2019 · 14 comments
Open

Tying up loose ends #48

sneakernets opened this issue Mar 15, 2019 · 14 comments
Assignees
Milestone

Comments

@sneakernets
Copy link
Owner

sneakernets commented Mar 15, 2019

The project has been dormant for a while, being pretty much "done" for the most part, save for some drum kits and some GS/XG instruments that are being done "when I get around to it". But there are some instruments that I think need some work now that I've heard them enough:

  • Pizzicato Strings: Sound too much like a steel drum somehow, needs some more timbre (but how?)
  • Brass Section needs to have detune applied on attack, this once worked, but somehow got changed. This only affects a few midis.
  • Shakuhachi needs a lot of work. It sounds pretty scratchy and bad in high ranges.
  • Tubular Bells ADSR needs some cleaning up. Sometimes the bell gets cut off (ADLMIDI issue? who knows)
  • Timbales need to be redone completely. There has to be a way to pull that sound off!
  • Clean up toms on other drum kits.
  • Finish the drum kits.
  • Make Rhodes Piano a little better. This has been tweaked a lot since I started, and it may have gotten worse.
  • Mayyybe tweak choirs a bit?
  • Orchestra Hit needs redoing. It's too fuzzy. I had a better sounding one before. Find it maybe?
  • Clarinet needs a little tweaking. It's much too "honk".
@sneakernets
Copy link
Owner Author

Here are some instruments I cleaned up a bit today
newinst.zip

@sneakernets
Copy link
Owner Author

and genmidi(gs) with new piano for testing

GENMIDI(piano).zip

@freq-mod
Copy link
Contributor

freq-mod commented Mar 15, 2019

May I leave this -
GENMIDI.zip
Long time ago, I improved maany instruments. I don't remember what I did after like 9 months, so you would unfortunately have to run through it and compare it against your GENMIDI. I can only say it's f54a1e9 and much more.

It features better orchestra hits - also check square wave based impact hit.
Choirs are also different.
Shakuhachi is redone.

@sneakernets
Copy link
Owner Author

@Papiezak omg thank you! I will go through it! maybe @Wohlstand would know if there is a way to do a quick diff on these in the editor? Would make my life SO much easier!

@freq-mod
Copy link
Contributor

freq-mod commented Mar 15, 2019

So I opened an issue ticket on an editor side.
BTW I think I edited Accordions as well, 2600 Sine.
I also added some GS instruments (OB Strings for example). I can go an isolate some of changed patches, but I don't know what to compare against 🤣
somanybanks

@freq-mod
Copy link
Contributor

Wll, @jpcima made a git-diff wopl bank text converter, but I didn't get it to work as intended, so I dumped my modded instrumnets manually.
newinst.zip - there it is. 68 instuments, do what you want with it. If you like, ping.
About SC-55 bank drum patches - I didn't dump them. Too much of a hassle.

@freq-mod
Copy link
Contributor

Comparison was made against GENMIDI(GS) file

@jpcima
Copy link

jpcima commented Mar 16, 2019

There is an integrated diff viewer at Wohlstand/OPL3BankEditor#143

@jpcima
Copy link

jpcima commented Mar 16, 2019

I make the diff available here for now. http://jpcima.sdf1.org/files/DMXOPL-diff.html
(which is the same as OPL3-BE in experimental branch)
Let me know if you spot anomalies.

@sneakernets
Copy link
Owner Author

Aaah I will take a look at all this later in the week (or tonight maybe), thank you so much! I can get this done/tweaked and a new release soon, surely!

@OlPainless
Copy link
Contributor

Hey everyone, it's been a while! I've been experimenting on and off on sounds, and one day I came across some timbale sounding sounds: timbales.zip . Thoughts?

@Wohlstand
Copy link

Sounds interesting

@OlPainless
Copy link
Contributor

OlPainless commented Nov 13, 2023

Sounds interesting

Thanks! I know it's not perfect, but it can work as a stop-gap until we get an even better one.

I could maybe take a look at the orchestral drum set. I have several midis that use it, but sound off since some drums are arranged differently compared to standard set. If that's okay?

@sneakernets
Copy link
Owner Author

That sounds great to me! I will make a branch with these. I don't want to break other projects that rely on this as a submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants