Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: highlight differences between two banks #141

Closed
freq-mod opened this issue Mar 15, 2019 · 7 comments
Closed

Feature: highlight differences between two banks #141

freq-mod opened this issue Mar 15, 2019 · 7 comments
Assignees

Comments

@freq-mod
Copy link
Contributor

freq-mod commented Mar 15, 2019

As requested by @sneakernets. (sneakernets/DMXOPL#48) Ability to

  • load two banks
  • compare instrument entries betwwen two banks, seek and find/highlight diffs

would be very helpful.

@Wohlstand
Copy link
Owner

I think, @jpcima is making some sort of...

@jpcima
Copy link
Collaborator

jpcima commented Mar 15, 2019

Right now there exists this utility which enables git-diff between files:
https://github.com/jpcima/wopl-textconv

@jpcima jpcima self-assigned this Mar 16, 2019
@jpcima jpcima mentioned this issue Mar 16, 2019
@Wohlstand
Copy link
Owner

Wohlstand commented Mar 18, 2019

I have merged that just now, and I did few fixes around you'll see 🦊 😉

@sneakernets
Copy link

I will check this out! thank you!!!

@freq-mod
Copy link
Contributor Author

I did a quick take a look and it looks fairly OK, the only weird thing is that when comparing o 2-op instrument against a completely different dual one, it only shows "it uses a different algorithm", forgoing any other differences.
But I guess it doesn't need to be that verbose 😉

@jpcima
Copy link
Collaborator

jpcima commented Mar 19, 2019

it only shows "it uses a different algorithm", forgoing any other differences.

It's on purpose, for compactness, as it would probably not offer a very useful output.
It would be a triviality to modify this behavior.

@freq-mod
Copy link
Contributor Author

freq-mod commented Apr 1, 2019

no feeedback from @sneakernets = no bugs.
Closing then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants