Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error message #137 #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Wrong error message #137 #155

wants to merge 2 commits into from

Conversation

christiangraves
Copy link

No description provided.

@Lucas-C
Copy link
Member

Lucas-C commented Nov 2, 2018

There are a couple of points to address in order for this PR to be merged :

@Lucas-C Lucas-C self-requested a review November 2, 2018 08:43
Lucas-C
Lucas-C requested changes Nov 2, 2018
View reviewed changes
Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to this project !
I made a few remarks on your PR.
Sadly it is a bit more involved that simply changing the label

@Lucas-C Lucas-C force-pushed the master branch 3 times, most recently from cf585dd to b6da477 Compare March 29, 2019 17:44
@thomaslhostis thomaslhostis force-pushed the master branch 5 times, most recently from dfc3237 to 9b54f7a Compare June 3, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucas-C Lucas-C Lucas-C requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christiangraves @Lucas-C