feat(space): export proposal id when executing #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orland0x
force-pushed
the
feat_export_proposal_id
branch
from
3b31e37
to
603bb04
Compare
Orland0x
changed the title
pscott
previously approved these changes
Oct 18, 2023
| @@ -63,6 +63,7 @@ contract AvatarExecutionStrategy is SimpleQuorumExecutionStrategy { | |||
| /// @param votesAbstain The number of abstaining votes. | |||
| /// @param payload The encoded transactions to execute. | |||
| function execute( | |||
| uint256 /* proposalId */, | |||
There was a problem hiding this comment.
should we specify in the doc that there's an unused param ?
There was a problem hiding this comment.
in the natspec comments?
pscott
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.