Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Selected Strategies Option #239

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ianrowan
Copy link

@ianrowan ianrowan commented Aug 9, 2023

Description of Changes

  • Allows proposers to more granularly select proposal's voting strategies from the set of active strategies
    • Adds a uint8[] function param to propose where caller can add indices of desired strategies per proposal
    • Uses _getSelectedBitArray internal function to compute a uint256 bit array per standard
    • Adds a selectedVotingStrategies to Proposal Struct
    • Creates a toggle to fallback to active proposal's if selected are not used prior to accumulating voting power(old behavior)

Considerations

  • Could check if active + selected strategies before using to allow for inactive strategies to not be used even when selected

Motivation

A project I'm working on has a need for different voting strategies per proposal and an attack vector occurs when users can select from all active strategies per proposal. The only current option to mitigate this is to deploy a space per proposal which seems inefficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant