fix: handle JSON-RPC errors from score-api #899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧿 Current issues / What's wrong ?
The
getScores
function does not take into account when the score-api is returning a json-rpc error object.💊 Fixes / Solution
Handle case when score-api is returning a json-rpc error object.
🚧 Changes
if
condition to return a promise rejection with the json-rpc error object when present.🛠️ Tests
getScores
function with dummy data, which will be handled and rejected by score-api