Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Validation for labels #1062

Merged
merged 3 commits into from
Sep 27, 2024
Merged

feat: Validation for labels #1062

merged 3 commits into from
Sep 27, 2024

Conversation

ChaituVR
Copy link
Member

Towards https://github.com/snapshot-labs/workflow/issues/143

Summary:

  • Validation for labels
  • Allows 100 labels with id, name, description and color

How to test:

  • Run yarn test
  • Try changing values in test/examples/space.json

@wa0x6e
Copy link
Contributor

wa0x6e commented Sep 27, 2024

How about always enforcing uppercase for color code ?

wa0x6e
wa0x6e approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit d287c01 into master Sep 27, 2024
4 checks passed
@ChaituVR ChaituVR deleted the feat-check-for-labels branch September 27, 2024 08:31
@ChaituVR ChaituVR mentioned this pull request Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e