fix: Increase choices limit for turbo (#1043)

* fix: Increase choices limit for turbo * v0.12.4
snapshot-labs · Aug 2, 2024 · 75f1a0b · 75f1a0b
1 parent 8f07c8c
commit 75f1a0b
Show file tree

Hide file tree

Showing 7 changed files with 1,022 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@snapshot-labs/snapshot.js",
-  "version": "0.12.3",
+  "version": "0.12.4",
   "repository": "snapshot-labs/snapshot.js",
   "license": "MIT",
   "main": "dist/snapshot.cjs.js",

diff --git a/src/schemas/proposal.json b/src/schemas/proposal.json
@@ -31,7 +31,10 @@
           "type": "array",
           "title": "choices",
           "minItems": 1,
-          "maxItems": 500
+          "maxLengthWithSpaceType": {
+            "default": 500,
+            "turbo": 1000
+          }
         },
         "type": {
           "type": "string",

diff --git a/src/schemas/update-proposal.json b/src/schemas/update-proposal.json
@@ -35,7 +35,10 @@
           "type": "array",
           "title": "choices",
           "minItems": 1,
-          "maxItems": 500
+          "maxLengthWithSpaceType": {
+            "default": 500,
+            "turbo": 1000
+          }
         },
         "type": {
           "enum": [

diff --git a/src/utils.ts b/src/utils.ts
@@ -155,7 +155,7 @@ ajv.addKeyword({
       validate.errors = [
         {
           keyword: 'maxLengthWithSpaceType',
-          message: `must NOT have more than ${schema[spaceType]} characters`,
+          message: `must not have more than ${schema[spaceType]}`,
           params: { limit: schema[spaceType] }
         }
       ];

diff --git a/test/examples/proposal-maxLengthWithSpaceType-error.json b/test/examples/proposal-maxLengthWithSpaceType-error.json
@@ -2,10 +2,19 @@
   {
     "instancePath": "/body",
     "keyword": "maxLengthWithSpaceType",
-    "message": "must NOT have more than 10000 characters",
+    "message": "must not have more than 10000",
     "params": {
       "limit": 10000
     },
     "schemaPath": "#/properties/body/maxLengthWithSpaceType"
+  },
+  {
+    "instancePath": "/choices",
+    "keyword": "maxLengthWithSpaceType",
+    "message": "must not have more than 500",
+    "params": {
+      "limit": 500
+    },
+    "schemaPath": "#/properties/choices/maxLengthWithSpaceType"
   }
 ]
diff --git a/test/examples/proposal-turbo.json b/test/examples/proposal-turbo.json
diff --git a/test/schema.spec.ts b/test/schema.spec.ts
@@ -12,6 +12,7 @@ import schemas from '../src/schemas';
 import proposalMaxLengthWithSpaceTypeError from './examples/proposal-maxLengthWithSpaceType-error.json';
 import spaceMaxItemsWithSpaceTypeError from './examples/space-maxItemsWithSpaceType-error.json';
 
+// Tests for default spaces
 describe.each([
   { schemaType: 'space', schema: schemas.space, example: space },
   { schemaType: 'proposal', schema: schemas.proposal, example: proposal },
@@ -30,7 +31,6 @@ describe.each([
 });
 
 // Tests for turbo spaces
-
 describe.each([
   { schemaType: 'space', schema: schemas.space, example: spaceTurbo },
   { schemaType: 'proposal', schema: schemas.proposal, example: proposalTurbo }
@@ -44,6 +44,7 @@ describe.each([
   });
 });
 
+// tests for default schema with turbo example, should fail
 describe.each([
   {
     schemaType: 'space',