chore: refactor providers

[bonustrack]

• Move each notification service providers and their function to a separated file
• Load proposal and subscribed addresses before sending notifications

[Todmy]

it could be improved by making requests execute in parallel

Suggested change

	for await (const walletsChunk of walletsChunks) {
	await beams.publishToInterests(walletsChunk, {
	web: {
	notification: {
	title: event.space,
	body: proposal.title,
	deep_link: `${process.env.SNAPSHOT_URI}/#/${event.space}/${event.id}`
	}
	}
	});
	const allPromises = walletsChunks.map(walletsChunk =>
	beams.publishToInterests(walletsChunk, {
	web: {
	notification: {
	title: event.space,
	body: proposal.title,
	deep_link: `${process.env.SNAPSHOT_URI}/#/${event.space}/${event.id}`
	}
	}
	})
	);
	await Promise.all(allPromises);

[wa0x6e]

Could even go one step further, by extracting the beams.publishToInterests to a sendEvent function, to be consistent with webhook.ts : send for building the batch, and sendEvent to sent each individual request.

[wa0x6e]

same for the discord side, we already have a sendMessage function, should be renamed to sendEvent, and all providers will have the same API

[Todmy]

nit: no need to use parseInt

[Todmy]

could be changed to

Suggested change

	event.token = sha256(`${to}${serviceEventsSalt}`);
	event.secret = sha256(`${to}${serviceEventsSalt}`);
	const headerSecret = sha256(`${to}${process.env.SERVICE_EVENTS_SALT}`);
	const headerSecret = sha256(`${to}${serviceEventsSalt}`);
	event.token = sha256(headerSecret);
	event.secret = sha256(headerSecret);

And probably better to use serviceEventsSalt instead of process.env.SERVICE_EVENTS_SALT since the last one could be empty

[bonustrack]

Hum here it would do a sha256 twice.

[wa0x6e]

Could create a new file providers/index.ts, with content :

import { send as sendDiscord } from './discord';
import { send as sendBeams } from './beams';
import { send as sendWebhook } from './webhook';

export default function send(event, proposal, subscribers) {
  sendBeams(event, proposal, subscribers);
  sendDiscord(event, proposal, subscribers);
  sendWebhook(event, proposal, subscribers);
}

So that events.ts could just import

import send from './providers';

and use a single send call

send(event, proposal, subscribers);