Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send errors to sentry #60

Merged
merged 5 commits into from
Jul 13, 2023
Merged

feat: send errors to sentry #60

merged 5 commits into from
Jul 13, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jul 7, 2023

This PR install sentry error monitoring

What it do

  • Send all uncaptured errors to sentry
  • Call capture() inside all catch, to send the error to sentry

The sendEvents to subscribers errors are not logged, since they fail for reasons out of out control (timeout, not found), and are ignored.

Notes

The required env variables NODE_ENV, 'SENTRY_DSN' and SENTRY_TRACE_SAMPLE_RATE have already been added to the server config

@wa0x6e wa0x6e requested review from Todmy and ChaituVR July 11, 2023 02:38
src/helpers/sentry.ts Show resolved Hide resolved
src/helpers/sentry.ts Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from Todmy July 12, 2023 10:17
Copy link
Contributor

@Todmy Todmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wa0x6e wa0x6e merged commit 9790211 into master Jul 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants