[do not merge yet] Move Discord bot to another repo #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
reviewed
Oct 28, 2022
Comment on lines
+83
to
+100
| async function sendEventToDiscordSubscribers(event: string, proposalId: string) { | ||
| try { | ||
| const url = `${discordBotUrl}/api/event-to-subscribers`; | ||
| const params = { | ||
| event, | ||
| proposalId | ||
| }; | ||
| await fetch(url, { | ||
| method: 'POST', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ params }) | ||
| }); | ||
|
|
||
| return console.log('[events] Notify Discord subscribers success'); | ||
| } catch (error) { | ||
| console.log("[events] Discord API Failure", error); | ||
| } | ||
| } |
There was a problem hiding this comment.
I feel like we should include this ${discordBotUrl}/api/event-to-subscribers in our webhooks table. sending events that way will be more secure.
There was a problem hiding this comment.
Could you potentially give me a reference link for that? 🙏
I can also implement authorization for the post request on the discord-bot side, then we can store i.e. a bearer token in the env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Background
This PR separates Discord bot from the current service.
Changes
sendEventToDiscordSubscribersinto an API call to the newdiscord-botRelated PRs
discord-bothas been merged and deployed 👉 PRTesting
Can be tested once the
discord-botis up an running to make sure everything is set correctly 🙏To dos
DISCORD_CLIENT_IDandDISCORD_TOKEN)DISCORD_BOT_URLin prod@ChaituVR @bonustrack it's not final yet but you can already have a look 🧹