Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[walletConnectNotify] fix: Remove icon field and throw error if there is an error in response #173

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[walletConnectNotify] fix: Remove icon field and throw error if there is an error in response #173

merged 2 commits into from
Jan 30, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Jan 29, 2024 •
edited
Loading

  • Not using icon field anymore
  • Right now we get an error in response, 
    {
  error: 'icon: Validation error: length [{"value": String(""), "min": Number(1), "max": Number(255)}]'
}
    and it is silent because we are not able to catch these errors

@ChaituVR ChaituVR requested a review from wa0x6e January 29, 2024 08:54
@ChaituVR ChaituVR changed the title fix: [walletConnectNotify] Throw error if there is an error in response [walletConnectNotify] fix: Remove icon field and throw error if there is an error in response Jan 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/providers/walletconnectNotify.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@ChaituVR ChaituVR requested review from wa0x6e and removed request for wa0x6e January 30, 2024 09:04
wa0x6e
wa0x6e approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit aff6f47 into master Jan 30, 2024
4 checks passed
@ChaituVR ChaituVR deleted the fix-silent-error branch January 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e