fix: ignore fetch error from test endpoint #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sentry issue: SNAPSHOT-WEBHOOK-17 |
ChaituVR
reviewed
Jan 17, 2024
| @@ -20,7 +20,7 @@ router.get('/test', async (req, res) => { | |||
|
|
|||
| return res.json({ url, success: true }); | |||
| } catch (e: any) { | |||
| if (e.code !== 'ERR_INVALID_URL') { | |||
There was a problem hiding this comment.
I feel like we can remove capture from this endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore all
FetchErrorfromapi/testendpoint, which are operation error from http (network timeout, error 500, etc ...).Error details returned already as JSON RPC response, no need to log them to our error logger.
Fix SNAPSHOT-WEBHOOK-17