Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add walletconnect notify provider for web3Inbox #162

Merged
merged 20 commits into from
Jan 16, 2024
Merged

feat: Add walletconnect notify provider for web3Inbox #162

merged 20 commits into from
Jan 16, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Jan 16, 2024 •
edited
Loading

Continued from #114

Credit to @devceline and @chris13524

TODO:

  • Before merging add the following env (others are already added)
WALLETCONNECT_NOTIFICATION_TYPE=

How to test:

  • Contact @ChaituVR for env values
  • Subscribe to your space by clicking the bell icon
    image
  • Go to https://app.web3inbox.com/ and subscribe to Snapshot App
  • Once you run yarn dev and a new proposal is started on space you subscribed, you should get notification on web3inbox
  • You should see a notification like
    image and on click, it should redirect to proposal

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 148 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/providers/walletconnectNotify.ts 0.00% 144 Missing and 1 partial ⚠️
src/providers/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@ChaituVR ChaituVR marked this pull request as ready for review January 16, 2024 12:20
@ChaituVR ChaituVR requested review from bonustrack and wa0x6e and removed request for bonustrack January 16, 2024 12:25
@ChaituVR ChaituVR changed the title Web3inbox feat: Add walletconnect notify provider for web3Inbox Jan 16, 2024
bonustrack
bonustrack approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ChaituVR ChaituVR merged commit d8997fc into master Jan 16, 2024
2 checks passed
@ChaituVR ChaituVR deleted the web3inbox branch January 16, 2024 12:49
@devceline devceline mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@wa0x6e wa0x6e Awaiting requested review from wa0x6e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaituVR @bonustrack @devceline