Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[passport-gated] Add at least N operator and checkExpired flag to Gitcoin Passport validation strategy #1410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xAurelius
Copy link
Contributor

@0xAurelius 0xAurelius commented Feb 21, 2024

Increases flexibility of the Gitcoin Passport validation strategy for use by KlimaDAO

Changes proposed in this pull request:

  • Adds a new ">=N" operator that allows for a fixed number of valid stamps to be required, rather than only "at least one" (OR) or "all" (AND)
  • Allows expired stamps to be considered valid by setting a boolean flag checkExpired which is true by default (i.e. expired stamps do not count by default)

@ChaituVR ChaituVR changed the title Add at least N operator and checkExpiration flag to Gitcoin Passport validation strategy [passport-gated] Add at least N operator and checkExpiration flag to Gitcoin Passport validation strategy Feb 22, 2024
@ChaituVR ChaituVR added the validation To run test cases related to validations label Feb 22, 2024
@0xAurelius
Copy link
Contributor Author

Not sure why the validation tests are failing, looks like a problem with the GitHub Actions CI setup when talking to Gitcoin Passport:
image

src/validations/passport-gated/README.md Outdated Show resolved Hide resolved
src/validations/passport-gated/examples.json Outdated Show resolved Hide resolved
@0xAurelius 0xAurelius changed the title [passport-gated] Add at least N operator and checkExpiration flag to Gitcoin Passport validation strategy [passport-gated] Add at least N operator and checkExpired flag to Gitcoin Passport validation strategy Feb 26, 2024
src/validations/passport-gated/index.ts Outdated Show resolved Hide resolved
src/validations/passport-gated/index.ts Outdated Show resolved Hide resolved
src/validations/passport-gated/index.ts Show resolved Hide resolved
src/validations/passport-gated/index.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation To run test cases related to validations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants