Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PicSnap to serve OpenGraph image #5

Open
wants to merge 121 commits into
base: main
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Apr 30, 2023

Fixes #3

TODO

  • Add image card for proposal
  • Add image card for space
  • Add generic image card
  • Cache image card
  • Refresh proposal image on proposal state change
  • Handle emoji
  • Add support for non-latin language (need fonts for each locale)

Those TODO have been scrapped, and will be raised again in another dedicated PR

  • Add image card for profile Will be implemented in another issue later, as this is extra, and have no planned use. See feat: Add OpenGraph image for user profile #10
  • Refresh space image on follows count update Space refresh event currently does not have trigger, as webhook service does not fire for this event type. As this will require some more complex works to detect new follows/unfollows on space, this feature is dropped from this PR, and will be raised in another dedicated issue. Space members count will be removed from image in the meantime. See feat: Refresh space OpenGraph image on follows count update #11

This PR is too big, some parts have bee extracted into these PR:

Queue system enable back the cache file generation on demand when cache is not available on fetch
@wa0x6e wa0x6e changed the base branch from base-pre-picsnap to add-api July 20, 2023 12:52
@wa0x6e wa0x6e changed the base branch from add-api to base-pre-picsnap July 20, 2023 12:52
@wa0x6e wa0x6e changed the base branch from base-pre-picsnap to main July 20, 2023 12:56
@wa0x6e wa0x6e changed the base branch from main to base-pre-picsnap July 20, 2023 12:56
@wa0x6e wa0x6e changed the title feat: Add open graph image feat: add PicSnap to serve OpenGraph image Jul 20, 2023
@wa0x6e wa0x6e changed the base branch from base-pre-picsnap to main July 21, 2023 14:02
@wa0x6e wa0x6e requested a review from ChaituVR July 21, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add PicSnap to serve OpenGraph image
3 participants