Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics endpoint #134

Merged
merged 3 commits into from
Jul 28, 2023
Merged

feat: add metrics endpoint #134

merged 3 commits into from
Jul 28, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jul 26, 2023

🧿 Current issues / What's wrong ?

From https://github.com/snapshot-labs/pitches/issues/18

💊 Fixes / Solution

This PR add a /metrics endpoint, exposing some basic express/node metrics, as well as custom metrics

🚧 Changes

  • Expose metrics via /metrics endpoint

🛠️ Tests

  • Go to http://localhost:3005/metrics

@wa0x6e wa0x6e requested a review from Todmy July 26, 2023 08:47
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #134 (483eb9e) into main (2e43c1a) will decrease coverage by 2.14%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   60.80%   58.66%   -2.14%     
==========================================
  Files          18       19       +1     
  Lines        1319     1367      +48     
  Branches       91       92       +1     
==========================================
  Hits          802      802              
- Misses        510      557      +47     
- Partials        7        8       +1     
Files Changed Coverage Δ
src/api.ts 0.00% <0.00%> (ø)
src/helpers/metrics.ts 0.00% <0.00%> (ø)
src/helpers/sentry.ts 11.62% <0.00%> (ø)
src/index.ts 0.00% <0.00%> (ø)
src/lib/queue.ts 0.00% <0.00%> (ø)
src/lib/storage/aws.ts 26.25% <0.00%> (ø)
src/lib/storage/file.ts 84.31% <0.00%> (ø)
src/webhook.ts 0.00% <0.00%> (ø)

Copy link
Contributor

@Todmy Todmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wa0x6e wa0x6e merged commit f07052e into main Jul 28, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants