Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HTML page for share links #12

Open
wants to merge 7 commits into
base: add-open-graph-image
Choose a base branch
from
Open

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented May 2, 2023

Fix #8

Add HTML Page with all the required meta tags, used for sharing snapshot.org space and proposal page

TODO

  • Add some UI and links for manual redirection
  • Fill missing data, use default text TBD
  • Extract the endpoint into a dedicated express app, only for share link ? (avoid mixing api and share url)

@wa0x6e
Copy link
Contributor Author

wa0x6e commented May 2, 2023

@bonustrack @samuveth @ChaituVR

For the descriptionm, what text should we display for:

  • space, when the about field is empty ? show proposal stats like x active proposals | Y closed proposals | M pending proposals ?
  • proposal: we remove-markdown and show the first X words ?

How should we show the proposal state ? Inside the title like [CLOSED] title ? or do we insert it in the description like [Closed] [X votes] description ?

I guess we're using the exact same url pattern, and just change the domain, e.g. http://link.snapshot.org/aave.eth/proposal/0x000 ?

@wa0x6e wa0x6e self-assigned this May 2, 2023
@wa0x6e
Copy link
Contributor Author

wa0x6e commented May 3, 2023

proposal description will be:

body without markdown, truncated to 300 chars, with prefix [State] x votes -

@wa0x6e
Copy link
Contributor Author

wa0x6e commented May 3, 2023

space description will be:

space.about, or if empty, show x members

@wa0x6e wa0x6e marked this pull request as ready for review May 3, 2023 13:44
@ChaituVR
Copy link
Member

ChaituVR commented May 3, 2023

space, when the about field is empty ? show proposal stats like x active proposals | Y closed proposals | M pending proposals ?

These fields are not available yet on snapshot graphql API 🙈

@wa0x6e
Copy link
Contributor Author

wa0x6e commented May 3, 2023

space, when the about field is empty ? show proposal stats like x active proposals | Y closed proposals | M pending proposals ?

These fields are not available yet on snapshot graphql API 🙈

Yes, that's why I fallbacked to only x members

@ChaituVR
Copy link
Member

ChaituVR commented May 3, 2023

space description will be:
space.about, or if empty, show x members

Would be nice if we can show x members even if we have about wyt?

@wa0x6e
Copy link
Contributor Author

wa0x6e commented May 3, 2023

done

@wa0x6e wa0x6e mentioned this pull request May 12, 2023
@wa0x6e wa0x6e changed the base branch from main to add-open-graph-image July 1, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add endpoint for sharable links
2 participants