feat: add PicSnap to serve OpenGraph image #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easier tests
Queue system enable back the cache file generation on demand when cache is not available on fetch
wa0x6e
changed the title
This was referenced Aug 23, 2023
…bs/snapshot-sidekick into add-open-graph-image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
TODO
Those TODO have been scrapped, and will be raised again in another dedicated PR
Add image card for profileWill be implemented in another issue later, as this is extra, and have no planned use. See feat: Add OpenGraph image for user profile #10Refresh space image on follows count updateSpace refresh event currently does not have trigger, as webhook service does not fire for this event type. As this will require some more complex works to detect new follows/unfollows on space, this feature is dropped from this PR, and will be raised in another dedicated issue. Space members count will be removed from image in the meantime. See feat: Refresh space OpenGraph image on follows count update #11This PR is too big, some parts have bee extracted into these PR:
Number of 'Files changes' will drop once they're merged