Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get turbo limits from database #494

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: get turbo limits from database #494

wants to merge 4 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jan 29, 2025 •
edited
Loading

Toward https://github.com/snapshot-labs/workflow/issues/315

This PR will pull the various limits from the database options tables, instead of hard coded values

How to test

  • Create proposals from flagged, verified and turbo spaces
  • It should return a limit error when over proposals count is over the limit for the specified space type

@wa0x6e wa0x6e requested a review from ChaituVR January 29, 2025 23:15
@wa0x6e wa0x6e marked this pull request as ready for review January 29, 2025 23:16
ChaituVR
ChaituVR requested changes Jan 30, 2025
View reviewed changes
src/helpers/options.ts Outdated Show resolved Hide resolved
src/helpers/options.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR January 30, 2025 15:49
@wa0x6e wa0x6e marked this pull request as draft January 30, 2025 19:28
@wa0x6e wa0x6e marked this pull request as ready for review January 30, 2025 19:32
@wa0x6e wa0x6e mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR