fix: rename params to skinSettings to follow hub convention

snapshot-labs · Feb 4, 2025 · 9ea928c · 9ea928c
1 parent 578aad9
commit 9ea928c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/helpers/actions.ts b/src/helpers/actions.ts
@@ -15,7 +15,7 @@ function normalizeSettings(settings: any) {
     };
   }
 
-  delete _settings.skinParams;
+  delete _settings.skinSettings;
 
   return _settings;
 }
@@ -44,11 +44,11 @@ export async function addOrUpdateSpace(id: string, settings: any) {
     normalizedSettings.domain || null
   ]);
 
-  await addOrUpdateSkin(id, settings.skinParams);
+  await addOrUpdateSkin(id, settings.skinSettings);
 }
 
-export async function addOrUpdateSkin(id: string, skinParams: Record<string, string>) {
-  if (!skinParams) return false;
+export async function addOrUpdateSkin(id: string, skinSettings: Record<string, string>) {
+  if (!skinSettings) return false;
 
   const COLORS = [
     'bg_color',
@@ -61,7 +61,7 @@ export async function addOrUpdateSkin(id: string, skinParams: Record<string, str
     'header_color'
   ];
 
-  const _params = snapshot.utils.clone(skinParams);
+  const _params = snapshot.utils.clone(skinSettings);
   COLORS.forEach(color => {
     if (_params[color]) {
       _params[color] = _params[color].replace('#', '');

diff --git a/src/writer/settings.ts b/src/writer/settings.ts
@@ -84,7 +84,7 @@ export async function verify(body): Promise<any> {
 
   if (!space?.turbo && !space?.domain) {
     if (msg.payload.domain) return Promise.reject('domain is a turbo feature only');
-    if (msg.payload.skinParams) return Promise.reject('skin is a turbo feature only');
+    if (msg.payload.skinSettings) return Promise.reject('skin is a turbo feature only');
   }
 
   const anotherSpaceWithDomain = (

diff --git a/test/integration/helpers/actions.test.ts b/test/integration/helpers/actions.test.ts
@@ -179,7 +179,7 @@ describe('helpers/actions', () => {
 
     it('adds a new skin when it does not exist', async () => {
       const testId = 'test-new-skin-ids';
-      const skinParams = {
+      const skinSettings = {
         bg_color: '#000000',
         link_color: '#ffffff',
         text_color: '#000000',
@@ -188,7 +188,7 @@ describe('helpers/actions', () => {
         heading_color: '#ffffff',
         primary_color: '#ffffff'
       };
-      await addOrUpdateSkin(testId, skinParams);
+      await addOrUpdateSkin(testId, skinSettings);
       const skin = (await db.queryAsync('SELECT * FROM skins WHERE id = ?', [testId]))[0];
       expect(skin).toEqual({
         id: testId,
@@ -206,7 +206,7 @@ describe('helpers/actions', () => {
 
     it('updates an existing skin', async () => {
       const testId = 'test-update-skin-id';
-      const skinParams = {
+      const skinSettings = {
         bg_color: '#FFFF00',
         link_color: '#FFFFFF'
       };
@@ -225,7 +225,7 @@ describe('helpers/actions', () => {
           'light'
         ]
       );
-      await addOrUpdateSkin(testId, skinParams);
+      await addOrUpdateSkin(testId, skinSettings);
       const skin = (await db.queryAsync('SELECT * FROM skins WHERE id = ?', [testId]))[0];
       expect(skin).toEqual({
         id: testId,