Fixed all warnings, all travis tests good #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the following 5 warnings that popped up when I compiled the git version with ghc-8.8.3:
src/Snap/Internal/Http/Server/Address.hs:70:5: warning: [-Woverlapping-patterns]
Pattern match is redundant
In a case alternative: _ -> ...
|
70 | _ -> fail "Unsupported address type"
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/Snap/Internal/Http/Server/Session.hs:38:1: warning: [-Wunused-imports]
The import of ‘Data.Monoid’ is redundant
except perhaps to import instances from ‘Data.Monoid’
To import instances alone, use: import Data.Monoid()
|
38 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/Snap/Internal/Http/Server/Socket.hs:178:40: warning: [-Wdeprecations]
In the use of ‘fdSocket’
(imported from Network.Socket, but defined in network-3.1.1.1:Network.Socket.Types):
Deprecated: "Use withFdSocket or unsafeFdSocket instead"
|
178 | go fileFd = do sockFd <- Fd
fmap
fdSocket sock| ^^^^^^^^
src/Snap/Internal/Http/Server/Session.hs:38:1: warning: [-Wunused-imports]
The import of ‘Data.Monoid’ is redundant
except perhaps to import instances from ‘Data.Monoid’
To import instances alone, use: import Data.Monoid()
|
38 | import Data.Monoid ((<>))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/Snap/Internal/Http/Server/Socket.hs:178:40: warning: [-Wdeprecations]
In the use of ‘fdSocket’
(imported from Network.Socket, but defined in network-3.1.1.1:Network.Socket.Types):
Deprecated: "Use withFdSocket or unsafeFdSocket instead"
|
178 | go fileFd = do sockFd <- Fd
fmap
fdSocket sock| ^^^^^^^^