feat: add snap config item for tray-icon; disable by default #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@merlijn-sebrechts can you take a look at this? :) |
merlijn-sebrechts
requested changes
Nov 24, 2023
|
On second thought, I think it should be disabled by default since upstream is getting a bunch of weird bug reports from our users complaining about broken systray support. Let's follow upstream on this to keep the peace. So just address my one request and we can merge this, thanks @jnsgruk ! |
|
@merlijn-sebrechts good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new snap configuration option
tray-icon. Whentray-iconis set totrue, thesignal-desktopbinary is launched with the--use-tray-iconflag.The option is set to
falseby default.Fixes #143
Fixes #153
Related: #195